Need reviewer for build-infra integration into jdk8/build

[David Holmes]

Main repo review ... well I looked at 95% of it ;-)

On 14/09/2012 12:38 PM, Kelly O'Hair wrote:
> 1. http://cr.openjdk.java.net/~ohair/openjdk8/repo-./webrev/
>
>    7197849: Update new build-infra makefiles
>
>    Lots and Lots of changes to the build-infra makefiles. Added top level Makefile, javadoc Makefile,
>    and a preliminary netbeans project definition.
>    Much work has gone into making the builds accurately compare to old makefile builds.

common/autoconf/autogen.sh:

!   # On Solaris /bin/sh doesn't support test -e but /usr/bin/test does.
!   TEST=`which test`

There's no guarantee that 'which test` == /usr/bin/test. Why not just 
set to /usr/bin/test?

common/autoconf/boot-jdk.m4:

Minor typo in error message: explicitely

common/autoconf/build-performance.m4:

+ 
ADD_JVM_ARG_IF_OK([-XX:PermSize=32m],SJAVAC_SERVER_JAVA,[$SJAVAC_SERVER_JAVA])

That's going to be a very short-lived option. :)

common/makefiles/HotspotWrapper.gmk

I think the use of the build-log-wrapper is wrong (see email thread on 
"Hotspot Build Stutter").


New files should only have 2012 copyright.

David
-----------------