Question about dead code in build-infra/common/autoconf/basics.m4

Fredrik Öhrström oehrstroem at gmail.com
Mon Sep 17 00:28:04 PDT 2012


2012/9/17 Tim Bell <tim.bell at oracle.com>:
> Based on my experiments this evening, lines 169...172 will never be
> executed, because OPENJDK_BUILD_OS does not have a value at this point. The
> if test at line 168 evaluates to false, even on Windows build systems.

You are absolutely right. It just a minor oversight when Magnus
restructured and
modularized the autconf source files. There are in fact three more places where
OPENJDK_BUILD_OS is used before its value is set. In BASIC_INIT and two
places where MAKE_SPACE_SAFE is called. I am sure it will be relatively easy
to fix.

//Fredrik



More information about the build-infra-dev mailing list