Need reviewer for build-infra integration into jdk8/build

[Kelly O'Hair]

So I have this week to get us integrated into jdk8/build before I go on vacation, and this is not going well for me.

First, I need everyone to curtail your pushes into build-infra unless you know it is rock solid and you
know it is ready for prime time. Please no more cleanups or tweaks unless they are really critical.
At least until we get past this integration.

I'll re-run my script and get all the latest build-infra changes ready and re-post new webrevs.
I will try and separate the changes better.

If I don't get a timely and explicit "GO or NO GO" from everyone, or this just won't be integrated.
I used the word "reviews" before and that is the wrong word, I'm NOT asking for code reviews per-se.
I am asking if "the" changes, as I have presented them to you, are ready to push into jdk8/build.
If there is anything wrong, someone would need to work with whoever made the change,
and fix it in build-infra. Then just ask me to re-sample build-infra and create new webrevs.
Please don't do this for non-critical issues like spelling errors, we can fix those later.

If any builds do not work (vis JPRT or otherwise), either new or old builds, I'll just NOT integrate,
and this may get delayed to after I get back from vacation sometime in Oct, or someone else needs to take over.

*** Any build breakage anywhere is a show stopper at this point. ***

Sorry if this sounds a bit sour, but I'm just trying to get this stuff integrated as cleanly as possible.

-kto


On Sep 13, 2012, at 7:38 PM, Kelly O'Hair wrote:

> 
> Ok, finally, separate webrevs per repository, please review what you can.
> There are 7 open repositories with changes.
> 
> ---
> 
> 1. http://cr.openjdk.java.net/~ohair/openjdk8/repo-./webrev/
> 
>  7197849: Update new build-infra makefiles
> 
>  Lots and Lots of changes to the build-infra makefiles. Added top level Makefile, javadoc Makefile,
>  and a preliminary netbeans project definition.
>  Much work has gone into making the builds accurately compare to old makefile builds.
> 
> 
> 2. http://cr.openjdk.java.net/~ohair/openjdk8/repo-corba/webrev/
> 3. http://cr.openjdk.java.net/~ohair/openjdk8/repo-jaxp/webrev/
> 4. http://cr.openjdk.java.net/~ohair/openjdk8/repo-jaxws/webrev/
> 
>  7197849: Update new build-infra makefiles
> 
>  Updated the makefiles/Makefile in these repos:
> 
> 
> 5. http://cr.openjdk.java.net/~ohair/openjdk8/repo-jdk/webrev/
> 
>  7197849: Update new build-infra makefiles
>  7198325: Fix more $(sort) issues on lnk commands in makefiles, making binaries more consistent
>  7198327: Fix mac warning error in hprof_init.c
>  7130909: Add a more general mechanism for customizing the build logic
> 
>  Lots and Lots of changes here too with more work into making the builds accurately compare.
>  Changed the old makefiles to sort object files and one hprof_init.c change which I will integrate
>  separately or at least put it in a separate changeset.
>  Also has some embedded makefile changes.
> 
> 
> 6. http://cr.openjdk.java.net/~ohair/openjdk8/repo-hotspot/webrev/
> 
>  7198329: Add $(sort) to object files used in links makes binaries more consistent
>  7172012: Make test-in-build an option (Queens)
> 
>  I'll try and integrate these hotspot changes through the hotspot-rt forest.
> 
> 
> 7. http://cr.openjdk.java.net/~ohair/openjdk8/repo-langtools/webrev/
> 
>  7197849: Update new build-infra makefiles
> 
>  I'm showing the whole webrev so you can see the differences between build-infra/jdk8/langtools and
>  jdk8/build/langtools, but I only integrate one file: makefiles/Makefile.
> 
> 
> -kto
>