Need reviewer for build-infra integration into jdk8/build

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Sep 14 05:42:29 PDT 2012


On 2012-09-14 04:38, Kelly O'Hair wrote:
> 6. http://cr.openjdk.java.net/~ohair/openjdk8/repo-hotspot/webrev/
>
>    7198329: Add $(sort) to object files used in links makes binaries more consistent
>    7172012: Make test-in-build an option (Queens)
>
>    I'll try and integrate these hotspot changes through the hotspot-rt forest.

I think we should try to untangle the different fixes here a bit more.

1) The Queens fixes is not quite properly done. I'm working on a 
separate webrev for those. I think I have fixed all remaining issues 
now, but I want to double-check and triple-test it first. :-)

2) Then there's the sort obj files

3) Then there's Fredrik's fixes to allow cross-compiling on platforms 
other than ppc and arm. Or more technically correct, to cross-compile to 
a platform which we support native compilation on. No-one had done this 
before, so it does not work. It's the fix in adlc.make, but this fix 
should also be done in solaris and bsd.

4) Then there's some fixes in linux/makefiles/defs.make to interact 
properly with the new build system (wrt the ARCH variables). It is 
possible that corresponding fixes should be done in bsd and solaris.

I believe they all warrant separate commits, so it will be possible in 
the future to trace the different changes to their different purposes.

/Magnus



More information about the build-infra-dev mailing list