RFR: 8192837 Need new test for release file info

Martin Buchholz martinrb at google.com
Mon Dec 18 19:40:48 UTC 2017


Hi Randy,

Your bugid link in the webrev is broken - points to bogus
https://bugs.openjdk.java.net/browse/https://bugs.openjdk.java.net/browse/JDK-8192837
Please fix.

OTOH, https://bugs.openjdk.java.net/browse/JDK-8192837 is not public -
please fix.

  92         String sJdkPath = System.getProperty("test.jdk");
  93         String sRuntime = System.getProperty("java.runtime.name");

This looks like Hungarian Notation, which is not normal in openjdk code, so
s/sJdkPath/jdkPath/ etc.


On Mon, Dec 18, 2017 at 8:55 AM, Randy Crihfield <Randy.Crihfield at oracle.com
> wrote:

> I have created an OpenJDK negative test that confirms the closed source
> files are not included in the SOURCE.
>
> Version of the actual test for review:
>
> http://cr.openjdk.java.net/~shurailine/8192837/webrev.00/
>
> Any comments/suggestions are welcome, also I will need a sponsor for it at
> the end…
>
> Randy
>
>


More information about the build-infra-dev mailing list