RFR: 8192837 Need new test for release file info

Randy Crihfield Randy.Crihfield at Oracle.com
Tue Dec 19 00:05:49 UTC 2017


On 12/18/17 02:40 PM, Martin Buchholz wrote:

Here it is Mr Martin

http://cr.openjdk.java.net/~shurailine/8192837/webrev.01/

Fixed the bugID link and changed the variables to what I believe you are 
asking for.
Also made the bug public.
Thanks for the help!

Randy

> Hi Randy,
>
> Your bugid link in the webrev is broken - points to bogus 
> https://bugs.openjdk.java.net/browse/https://bugs.openjdk.java.net/browse/JDK-8192837 
>
> Please fix.
>
> OTOH, https://bugs.openjdk.java.net/browse/JDK-8192837 is not public - 
> please fix.
>
>    92         String sJdkPath = System.getProperty("test.jdk");
>    93         String sRuntime = System.getProperty("java.runtime.name  <http://java.runtime.name>");
> This looks like Hungarian Notation, which is not normal in openjdk 
> code, so s/sJdkPath/jdkPath/ etc.
>
>
> On Mon, Dec 18, 2017 at 8:55 AM, Randy Crihfield 
> <Randy.Crihfield at oracle.com <mailto:Randy.Crihfield at oracle.com>> wrote:
>
>     I have created an OpenJDK negative test that confirms the closed
>     source files are not included in the SOURCE.
>
>     Version of the actual test for review:
>
>     http://cr.openjdk.java.net/~shurailine/8192837/webrev.00/
>     <http://cr.openjdk.java.net/%7Eshurailine/8192837/webrev.00/>
>
>     Any comments/suggestions are welcome, also I will need a sponsor
>     for it at the end…
>
>     Randy
>
>



More information about the build-infra-dev mailing list