latest patch
Roman Kennke
roman at kennke.org
Mon Apr 16 14:28:42 PDT 2012
Hi Glen,
> Here is the combined patches of everything I have so far. Sorry I
> should have been committing locally so I could have had these as
> separate patches. If this trips you up I can repatch things in after
> you commit the other ones if you prefer, might be easier to just use
> this one though as I see my first patch was missing imports.
>
> I still want to add a couple of test cases for what these address.
> The missing one being the mouse clicked events and the click count
> piece which was preventing being able to go into cell editing in a
> JTable. There is still an outstanding issue around double click as
> the click count will have to increase to 2 in that case (3 for triple
> click, etc.). I'll see if I can come up with something for that.
I committed your fix and test for the popupTrigger. I also committed
your testcase for the focus issue, however, I did not agree with your
fix (as you suspected). The real fix is to keep track of the opened
windows, and when one is closed, hand focus back to the previous one. I
also committed this. Is there anything else you have in the pipeline?
Otherwise I'd prepare a release soon (tomorrow or so).
Those latest changes have also been deployed to Cacio's snapshots maven
repository at:
https://oss.sonatype.org/content/repositories/snapshots
Also, a small hint to make our lives easier: it would be helpful to send
patches in 'hg diff --git' format (the --git is optional, but it helps
when moving, copying or renaming files). For some reason, Mercurial did
not like to hg qimport your patches, so I had to manually patch it,
figure out what is the correct --p etc. Not a big deal, but hg qimport
is just so much nicer ;-)
Cheers, Roman
More information about the caciocavallo-dev
mailing list