latest patch

[Glen Schrader]

On 2012-04-16, at 3:28 PM, Roman Kennke wrote:

> Hi Glen,
> 
> I committed your fix and test for the popupTrigger. I also committed
> your testcase for the focus issue, however, I did not agree with your
> fix (as you suspected). The real fix is to keep track of the opened
> windows, and when one is closed, hand focus back to the previous one. I
> also committed this.

Thanks for committing this, yes looking at your change that is a much better solution.

> Is there anything else you have in the pipeline?
> Otherwise I'd prepare a release soon (tomorrow or so).

Looks like the mouse click event stuff was missed.  I had the following prior to line 73 of CTCRobotPeer:

	CTCEventSource.getInstance().postEvent(mouseEvent(MouseEvent.MOUSE_CLICKED, MouseEvent.BUTTON1_DOWN_MASK, false))

I didn't have a test for that but could whip one up pretty quickly.

The only other thing I wanted to get to but haven't had a chance to look at is the click count.  I'm working around that issue right now by having this in the CTCRobotPeer.mouseEvent method: 
 
	ev.setClickCount(1);

I think this is "more right" than 0 which is what it's defaulting to right now.


> Those latest changes have also been deployed to Cacio's snapshots maven
> repository at:
> 
> https://oss.sonatype.org/content/repositories/snapshots
> 
> 
> Also, a small hint to make our lives easier: it would be helpful to send
> patches in 'hg diff --git' format (the --git is optional, but it helps
> when moving, copying or renaming files). For some reason, Mercurial did
> not like to hg qimport your patches, so I had to manually patch it,
> figure out what is the correct --p etc. Not a big deal, but hg qimport
> is just so much nicer ;-)
> 

Sure no problem, I was just being lazy and let my IDE do the patch so I was curious if it would apply ok.

Looking forward to the release!

Thanks,
Glen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120416/7697ce8c/attachment.html