Classfile API CodeElement.Kind cleanup

[Brian Goetz]

Overall this change looks fine.  I would rather keep the Opcode values 
for the pseudos, though, because I would rather not use null as a 
sentinel (see the constructors for, eg, ExceptionCatchImpl, which passes 
null to its super-ctor.)  Even if this is the only place these are used; 
these nulls are an error waiting to happen.  (This seems like a small 
bit to roll back.)






On 10/12/2022 2:57 AM, Adam Sotona wrote:
>
> It seems that there are some issues delivering my replies, so 
> forwarding directly:
>
> I’ve prepared CodeElement.Kind cleanup pull request:
>
> https://github.com/openjdk/jdk-sandbox/pull/41
>
>   * CodeElement.Kind moved to Opcode
>   * CodeElement::opcode and CodeElement::sizeInBytes moved down to
>     Instruction
>   * removed all pseudo Opcodes and Kinds
>
> Please review.
>
> Thanks,
>
> Adam
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20221013/5ccd8021/attachment-0001.htm>