Experience report

[Dan Heidinga]

I've updated the PR to include the following:
* CE.adding/addingSymbols methods
* a List<CE> deduplicate(List<CE>) method that removes duplicate entries
from the List
* equals() methods to the ConcreteEntry subclasses

Let me know if this fits with the intended approach for the jdk.classfile
library.

https://github.com/openjdk/jdk-sandbox/pull/35

--Dan

On Wed, Aug 24, 2022 at 2:55 PM Brian Goetz <brian.goetz at oracle.com> wrote:

> I'd say let's give this a try and see what we think of the resulting
> transformation code.  It feels like right-sizing the overhead at first look.
>
> On 8/24/2022 9:22 AM, Dan Heidinga wrote:
>
>
>>
> I took another pass through the Attributes that deal with Lists of things
> and most cases are well handled by existing List helpers.  It's only the
> CE/CD cases that need data conversion and would therefore benefit from
> additional methods to create their lists.
>
> If we expect to be content with these 4 methods, then adding them as
> static methods on ClassEntry seems reasonable. It makes them easy to find
> and avoids a garbage "Helpers/Utils" class.  If we expect more of these
> methods (and I currently don't but that may be lack of imagination), then a
> garbage class might be better.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20220912/7b93801e/attachment.htm>