RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

Sat Dec 4 05:04:10 UTC 2021

On Fri, 3 Dec 2021 20:20:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Can't we call it explicitly in the case where colorBits == NULL?

I would use the default handlers for bad_alloc since they can be changed in feature and keeping code that is intended to be used in two places is usually not a good idea.

> Alternatively, since you don't use the macros for try and catch, you can re-arrange code and perform cleanup after the catch-block. Just an idea… It may not work.

That might require a lot of code reformatting and the benefits are unclear.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6473