RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

Alexey Ivanov aivanov at openjdk.java.net
Sat Dec 4 19:36:17 UTC 2021


On Sat, 4 Dec 2021 05:01:06 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> > Alternatively, since you don't use the macros for try and catch, you can re-arrange code and perform cleanup after the catch-block. Just an idea… It may not work.
> 
> That might require a lot of code reformatting and the benefits are unclear.

I tried it, it doesn't, [see this diff](https://github.com/aivanov-jdk/jdk/commit/ccf7500cf0e4614b12c0882204a81d928fce0a82). It's close to your latest code, however, there's only one `catch` that handles both allocations and there are no `if`'s inside the `try`-block.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6473



More information about the client-libs-dev mailing list