RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Fri Nov 12 14:58:42 UTC 2021


On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719. Also https://developer.apple.com/forums/thread/105719 states that even if they set app deployment target they need to explicitly set deployment in "xcrun metal".
>> 
>> Made same change to use -mmacosx-version-min=10.12.00 in our make file. Whether we should keep 10.12.00 or 10.13/14 is open to discussion for metal pipeline.
>> 
>> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) has confirmed that patch resolves the issue.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Macro for version

If we leave -mmacosx-version-min unspecified, will metal pick another value by default silently? And if so, might we be actually lowering the min version even if specifying 10.14?

In any case, it seems that any change here will need thorough testing both on Oracle CI systems and to make sure it solves @jayathirthrao's problem.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6346



More information about the client-libs-dev mailing list