RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

Alexey Ivanov aivanov at openjdk.java.net
Thu Nov 18 16:49:40 UTC 2021


On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It's a little cleanup: make sure `frame` is accessed from EDT only, remove unused variables and imports.

I've been working with this test, I found what seemed wrong and so I decided to fix it.

I'm sure there are many tests which access some variables from different threads without synchronisation, there could be tests which create or access Swing UI not from EDT. Yet it wasn't my intention to fix all tests. I believe we've been updating the tests and resolve such problems on one-by-one basis when it gets noticed, when a test gets updated etc.

If you think it's not worth it, I'll withdraw my PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6455



More information about the client-libs-dev mailing list