RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Fri Nov 19 05:25:36 UTC 2021


On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It's a little cleanup: make sure `frame` is accessed from EDT only, remove unused variables and imports.

I am not sure on this as those 100+ tests which accesses frame variable outside EDT before it calls dispose  is not failing in CI testing and also locally so to modify this particular test only does not make sense to me.
But anyway, it's your call...
If you still want to take it forward, regarding the test, I will request to add a delay of 1sec after l56 after we make the frame visible, same way we normally do for other swing reg tests.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6455



More information about the client-libs-dev mailing list