RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails [v2]
Masanori Yano
myano at openjdk.java.net
Fri Oct 15 11:09:26 UTC 2021
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this problem is that paint() works one time only. Painting area is not guaranteed when showing a window.
>
> I think this behavior should be removed for purpose of this test (`@summary: Verifies that copyArea() works properly`). Also, this program uses a Robot, but implements waiting logic by itself. This logic should be replaced to Robot API.
>
> This fix works fine in Windows, so this test can be removed from ProblemList.txt. I don't have a Mac environment, so can someone please confirm that this fix will work on Mac?
Masanori Yano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
- Merge branch 'master' of https://github.com/masyano/jdk into 7001973
- 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
- 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5491/files
- new: https://git.openjdk.java.net/jdk/pull/5491/files/9b3f57a2..52c5ca79
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5491&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5491&range=00-01
Stats: 54722 lines in 1656 files changed: 35144 ins; 11674 del; 7904 mod
Patch: https://git.openjdk.java.net/jdk/pull/5491.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5491/head:pull/5491
PR: https://git.openjdk.java.net/jdk/pull/5491
More information about the client-libs-dev
mailing list