RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails [v2]

Sergey Bylokhov serb at openjdk.java.net
Sat Oct 23 19:37:14 UTC 2021


On Fri, 15 Oct 2021 11:09:26 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Could you please review the 7001973 fixes?
>> 
>> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this problem is that paint() works one time only. Painting area is not guaranteed when showing a window.
>> 
>> I think this behavior should be removed for purpose of this test (`@summary: Verifies that copyArea() works properly`). Also, this program uses a Robot, but implements waiting logic by itself. This logic should be replaced to Robot API.
>> 
>> This fix works fine in Windows, so this test can be removed from ProblemList.txt. I don't have a Mac environment, so can someone please confirm that this fix will work on Mac?
>
> Masanori Yano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
>  - Merge branch 'master' of https://github.com/masyano/jdk into 7001973
>  - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
>  - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

This looks fine, but should be checked on other platforms Linux/macOS since it can uncover some issues there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5491



More information about the client-libs-dev mailing list