Fwd: Re: Allow overriding lp and lpr binary paths in PSPrintJob

Rolf van Kleef rolf at vankleef.me
Tue Oct 26 14:02:12 UTC 2021


> Well ..
> 
> 1) Please read the comment the bots added to your PR.
> There are steps you need to take before we can even look at your contribution.
> 
> 2) PRs need a JBS bug ID else the bots will still reject it.
> You'll need to submit an RFE at bugreport.java.com and go from there.

I have submitted a bug, and added a bug ID to the PR. The only remaining requirement appears to e
acquiring a review.

> 3) I understand your problem up to a point but we'd need to think about the proposed solution
> and why your Linux doesn't put lpr in the standard place. There could be legitimate
> security concerns about allowing such an over-ride.
> Perhaps you need a port of OpenJDK to that distro which you don't name ?

This specifically concerns Flatpak, where it is entirely non-trivial to place files outside of the
/app directory. I would be interested to hear about these aforementioned security concerns.
Presumably if someone is able to set system properties, there are bigger problems?

I am very open to discussing alternative solutions.

> -phil
> 
> On 10/22/21 5:42 AM, Rolf van Kleef wrote:
> 
>> I am not sure about whether this is the correct list for this, or whether this is an appropriate
>> message for this list, but I have been told to send an email here regarding a PR I submitted on
>> GitHub.
>> 
>> I recently ran into trouble with printing on Linux, where the lpr binary was on a non-standard path
>> (not in /usr/bin/lpr). After looking in the code, I found out that this path cannot be overridden.
>> It seems that such paths should be able to be overriden, and so, I propose to add a system property
>> named "sun.print.lprPath" and "sun.print.lpPath" to override these paths. See the PR below.
>> 
>> https://github.com/openjdk/jdk/pull/6052
>> 
>> Regards,
>> Rolf van Kleef



More information about the client-libs-dev mailing list