RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]
Pankaj Bansal
pbansal at openjdk.java.net
Tue Sep 14 16:42:02 UTC 2021
On Tue, 14 Sep 2021 00:10:26 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:
>> Problem :
>> 1) Test case was failing with following exception
>> test result: Error. Parse Exception: Arguments to `manual' option not supported: yes
>> 2) After removing =yes/no Parser exception is not seen but test UI will show and closes immediately where the user cannot see what is on the frame.
>>
>> Fix :
>> 1) Add frame to show the test instructions.
>> 2) Added timeout for the test case.
>> 3) Show the test UI until either test case gets timeout or user press pass or fail button.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed minor issue
test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 126:
> 124: instructionTextArea.setText(INSTRUCTIONS);
> 125: instructionTextArea.setEditable(false);
> 126: instructionTextArea.setBackground(Color.white);
Is there a particular reason to set the background as white? It is better if the background and foreground colors are set by the L&F itself. I have fixed couple of bugs for GTKL&F, where the panel background color was set manually and then the L&F chosen color for foreground/Text was also same, so the text was not visible at all.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5503
More information about the client-libs-dev
mailing list