RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

lawrence.andrews github.com+87324768+lawrence-andrew at openjdk.java.net
Tue Sep 14 17:02:13 UTC 2021


On Tue, 14 Sep 2021 16:38:34 GMT, Pankaj Bansal <pbansal at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed minor issue
>
> test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 126:
> 
>> 124:         instructionTextArea.setText(INSTRUCTIONS);
>> 125:         instructionTextArea.setEditable(false);
>> 126:         instructionTextArea.setBackground(Color.white);
> 
> Is there a particular reason to set the background as white? It is better if the background and foreground colors are set by the L&F itself.  I have fixed couple of bugs for GTKL&F, where the panel background color was set manually and then the L&F chosen color for foreground/Text was also same, so the text was not visible at all.

Nice point about look and feel. Sure, let me remove the background color.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5503



More information about the client-libs-dev mailing list