RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v3]

lawrence.andrews github.com+87324768+lawrence-andrew at openjdk.java.net
Fri Sep 17 14:47:07 UTC 2021


On Fri, 17 Sep 2021 14:05:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplified test UI
>
> test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 49:
> 
>> 47: import java.awt.geom.RoundRectangle2D;
>> 48: import java.util.concurrent.CountDownLatch;
>> 49: import java.util.concurrent.TimeUnit;
> 
> I'd also suggest sorting imports alphabetically. Your IDE could do this for you with its Optimize Imports command.

Done

> test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 63:
> 
>> 61:         g2d.fillRect(0,0,getSize().width, getSize().height);
>> 62: 
>> 63:         test1(g.create(0, 0, 500, 200));
> 
> Not an issue, however, with the additional space the width and height are aligned in all the lines. :)

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/5503



More information about the client-libs-dev mailing list