RFR: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again) [v2]

Alexander Zvegintsev azvegint at openjdk.java.net
Wed Apr 13 23:18:07 UTC 2022


> This test has two undecorated frames: 
> 
> 1. background, 300x300
> 2. shaped foreground, 200x200
> 
> After displaying this frames it tries to check color outside of shape but within frame 2 bounds.
> 
> Unfortunately, on Linux and macOS there is a shadow around the shaped frame:
> ![image](https://user-images.githubusercontent.com/77687766/163270586-8dd97e93-582f-481f-999d-f08d4aaafba1.png)
> (changed color to green to make it more noticeable).
> 
> One way to fix the test would be to add tolerance to color check.
> But with old check points blue color may vary in 222-255 range, which is a bit too much.
> 
> Instead of this I made this shaped window  the size of background window. 
> This allows us to move check points away from shape border and its shadow, but still be able to check whether shape is applied or not.
> 
> Testing is green on all platforms.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  check around corners

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8233/files
  - new: https://git.openjdk.java.net/jdk/pull/8233/files/d169081d..dbef3618

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8233&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8233&range=00-01

  Stats: 27 lines in 1 file changed: 15 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8233.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8233/head:pull/8233

PR: https://git.openjdk.java.net/jdk/pull/8233



More information about the client-libs-dev mailing list