RFR: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again) [v2]

Sergey Bylokhov serb at openjdk.java.net
Thu Apr 14 09:17:18 UTC 2022


On Wed, 13 Apr 2022 23:18:07 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> This test has two undecorated frames: 
>> 
>> 1. background, 300x300
>> 2. shaped foreground, 200x200
>> 
>> After displaying this frames it tries to check color outside of shape but within frame 2 bounds.
>> 
>> Unfortunately, on Linux and macOS there is a shadow around the shaped frame:
>> ![image](https://user-images.githubusercontent.com/77687766/163270586-8dd97e93-582f-481f-999d-f08d4aaafba1.png)
>> (changed color to green to make it more noticeable).
>> 
>> One way to fix the test would be to add tolerance to color check.
>> But with old check points blue color may vary in 222-255 range, which is a bit too much.
>> 
>> Instead of this I made this shaped window  the size of background window. 
>> This allows us to move check points away from shape border and its shadow, but still be able to check whether shape is applied or not.
>> 
>> Testing is green on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   check around corners

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8233



More information about the client-libs-dev mailing list