Integrated: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
Alexander Zvegintsev
azvegint at openjdk.java.net
Sat Apr 16 10:05:32 UTC 2022
On Wed, 13 Apr 2022 21:28:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
> This test has two undecorated frames:
>
> 1. background, 300x300
> 2. shaped foreground, 200x200
>
> After displaying this frames it tries to check color outside of shape but within frame 2 bounds.
>
> Unfortunately, on Linux and macOS there is a shadow around the shaped frame:
> 
> (changed color to green to make it more noticeable).
>
> One way to fix the test would be to add tolerance to color check.
> But with old check points blue color may vary in 222-255 range, which is a bit too much.
>
> Instead of this I made this shaped window the size of background window.
> This allows us to move check points away from shape border and its shadow, but still be able to check whether shape is applied or not.
>
> Testing is green on all platforms.
This pull request has now been integrated.
Changeset: e5041ae3
Author: Alexander Zvegintsev <azvegint at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/e5041ae3d45b43be10d5da747d773882ebf0482b
Stats: 116 lines in 2 files changed: 44 ins; 28 del; 44 mod
8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
Reviewed-by: serb
-------------
PR: https://git.openjdk.java.net/jdk/pull/8233
More information about the client-libs-dev
mailing list