RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v4]
Harshitha Onkar
honkar at openjdk.org
Fri Aug 5 00:46:02 UTC 2022
On Thu, 21 Jul 2022 00:27:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds of test instruction frame are added to PassFailJFrame to handle positioning of multiple test frames.
>>
>> In scenarios where multiple test windows might be present, the test windows might overlap the instruction frame. In order to fix this TOP_LEFT_CORNER position option is added that positions the test instruction frame at top left corner with main test window below it.
>>
>> Additionally `getInstructionFrameBounds()` is added to obtain the position and dimensions of test instruction frame.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> added screen insets to account for taskbar position, doc changes
The recent commit has the following changes -
- Toolkit sync and Thread.sleep added to push the frame's updated location to window manager
- Position of `setVisible` for instruction frame moved from `createUI `to `positionTestWindow`. Before this change the frame was initially visible for sometime in its initial location for a few seconds before moving to its final position set in `positionTestWindow`.
- For the same reason as above, the `setVisible` for `testWindow` is called after `positionTestWindow()` at test-level.
-------------
PR: https://git.openjdk.org/jdk/pull/9525
More information about the client-libs-dev
mailing list