RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v4]

Harshitha Onkar honkar at openjdk.org
Mon Aug 15 18:24:18 UTC 2022


On Fri, 29 Jul 2022 22:01:44 GMT, Phil Race <prr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added screen insets to account for taskbar position, doc changes
>
> Well .. there surely must be test scenarios where a Frame is required. Perhaps the test moves it, iconifies, needs
> a specific size .. expects focus to move in a certain order between components in the frame .. wants to use
> heavyweight AWT components .. .in some of these I expect the extra instruction part doesn't matter but you only have to find ONE case where it matters .. then there's the fact you'd have to rewrite all the existing tests. And why a JSplitPane, anyway ? Odd choice. 
> 
> I can imagine that it might be interesting to add a new version that works with a JPanel as the container for the test and let a test author decide if they want to use that for future tests.

@prrace PR has been updated with suggested changes and ready for re-review.

-------------

PR: https://git.openjdk.org/jdk/pull/9525



More information about the client-libs-dev mailing list