RFR: JDK-8297449: Update JInternalFrame Metal Border code [v4]

[Alexey Ivanov]

On Tue, 29 Nov 2022 21:42:02 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Updated Metal Border code for JInternalFrame. 
>> 
>> - Added instanceof check before casting Graphics to G2D.
>> - Replaced roundHalfDown with Region.clipRound()
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review changes

Marked as reviewed by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line 292:

> 290:             int height;
> 291:             int xtranslation;
> 292:             int ytranslation;

I wonder why you changed the order of declaration.

Is it for consistency with the `else`-block? What about the `if` itself then?

It's very minor though.

-------------

PR: https://git.openjdk.org/jdk/pull/11305