RFR: JDK-8297449: Update JInternalFrame Metal Border code [v4]

Harshitha Onkar honkar at openjdk.org
Thu Dec 1 18:15:07 UTC 2022


On Thu, 1 Dec 2022 14:48:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review changes
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line 292:
> 
>> 290:             int height;
>> 291:             int xtranslation;
>> 292:             int ytranslation;
> 
> I wonder why you changed the order of declaration.
> 
> Is it for consistency with the `else`-block? What about the `if` itself then?
> 
> It's very minor though.

Updated

-------------

PR: https://git.openjdk.org/jdk/pull/11305



More information about the client-libs-dev mailing list