RFR: JDK-8266245: AWT Test FullScreenInsets.java fails due to incorrect pixel color and wrong window bounds [v2]
Harshitha Onkar
honkar at openjdk.org
Mon Dec 5 22:28:45 UTC 2022
On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> The above test was failing due to incorrect pixel color and wrong window bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevice's DefaultConfig bounds (this test checks FullScreen functionality on multiple screen devices).
>> - Color tolerance has been added for color check
>> - Instead of scanning the full screen to check pixel color, vertical and horizontal scans are done at the far right and bottom end to ensure that window is in full screen mode w.r.t to screen device and the window bounds are as expected.
>>
>> CI testing passes on all platforms (tested 50 times per platform).
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> frame changed back to decorated and exclude on linux
Updated changes -
- device.getDefaultConfiguration().getBounds() is used to compare with the full-screen window size instead of DisplayMode's bounds for reasons mentioned here [11462#](https://github.com/openjdk/jdk/pull/11462#discussion_r1038598610)
- Frames are reverted to be decorated. The test passes on all platforms except linux when decorated frames are used. On Linux, there is a height mismatch of the full-screen window and a black bar is seen at the top of full screen window as shown in the screenshots below. For the above reason and review suggestion mentioned here [11462#](https://github.com/openjdk/jdk/pull/11462#discussion_r1039167448), the following test has been excluded on linux.

-------------
PR: https://git.openjdk.org/jdk/pull/11462
More information about the client-libs-dev
mailing list