RFR: JDK-8266245: AWT Test FullScreenInsets.java fails due to incorrect pixel color and wrong window bounds [v2]

Sergey Bylokhov serb at openjdk.org
Tue Dec 6 04:13:14 UTC 2022


On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The above test was failing due to incorrect pixel color and wrong window bounds on Mac-ARM, Windows and Linux platforms.
>> 
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevice's DefaultConfig bounds (this test checks FullScreen functionality on multiple screen devices).
>> - Color tolerance has been added for color check
>> - Instead of scanning the full screen to check pixel color, vertical and horizontal scans are done at the far right and bottom end to ensure that window is in full screen mode w.r.t to screen device and the window bounds are as expected.
>> 
>> CI testing passes on all platforms (tested 50 times per platform).
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   frame changed back to decorated and exclude on linux

test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java line 44:

> 42:  * @bug 8003173 7019055
> 43:  * @summary Full-screen windows should have the proper insets.
> 44:  * @requires (os.family != "linux")

You should not exclude the test on the platform which has a bug in it. On Linux, this test fails if a non-accelerated java2d pipeline is used, and we just "maximize the frame", this problem is similar to Windows described in JDK-7019055.

Note that you deleted the reference to this bug https://bugs.openjdk.org/browse/JDK-8266245 from problem list, take a look at the images attached to that report, both of them have black/empty rectangle on the top. This looks similar to the initial bug this test was created https://bugs.openjdk.org/browse/JDK-8003173

So looks like this is not a test issue on all platforms, other than the  `device.getDefaultConfiguration().getBounds()` usage.

-------------

PR: https://git.openjdk.org/jdk/pull/11462



More information about the client-libs-dev mailing list