RFR: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled [v2]

[Alexey Ivanov]

On Mon, 12 Dec 2022 18:27:24 GMT, SWinxy <duke at openjdk.org> wrote:

>> Many `installDefaults` methods set the font, foreground, and background on objects but their inverse methods `uninstallDefaults` do not remove them. I've added an inverse method to remove the colors and font to call for the `uninstallDefaults` methods that install defaults.
>> 
>> `AquaButtonUI` can call its super since it would otherwise be repeated code. `BasicComboBoxUI` (weirdly) installs the properties again when it should be uninstalling them, so I changed.
>> 
>> I noticed that, in a few subclasses, only one of calls to the super of `installDefaults` and `uninstallDefaults` are made. That is, an overridden `installDefaults` may call its super while the overridden `uninstallDefaults` does not call its super (or vise versa). These classes are: `AquaTabbedPaneUI`, `SynthMenuItemUI`, `SynthSplitPaneUI`, and `XTextAreaPeer`.
>> 
>> Sorry I couldn't write a test; I wasn't sure how I should have accessed the protected variable aside from creating extending classes for each class that changed.
>> 
>> See also #6603, where this issue was discovered.
>
> SWinxy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Sync with CSR
>   
>   Only difference is that I added an Oxford comma

This change cause 23 test cases to fail across the platforms:

* `sanity/client/SwingSet/src/SwingSet2DemoTest.java`;
* `javax/swing/GraphicsConfigNotifier/StalePreferredSize.java`;
* two closed tests.

**One JCK test** fails; from a quick look, it's because the font is now uninstalled where it wasn't previously.

-------------

PR: https://git.openjdk.org/jdk/pull/10565