[jdk20] RFR: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus [v3]

Alexander Zvegintsev azvegint at openjdk.org
Sat Dec 17 01:17:51 UTC 2022


On Fri, 16 Dec 2022 20:05:16 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Set the text caret to be visible but not blinking on the non-editable text area. Fix the regression test that becames unstable after the change.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handle different cases where refresh rate can be set when component is in different states causing some confused result.
>   Also added code that in case of non-editable text component reports the saved blink rate to avoid any problems with JCK testing.

src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 370:

> 368: 
> 369:     private int savedBlinkRate = 0;
> 370:     private boolean blinkRateSaved = false;

Naming of `savedBlinkRate` and `blinkRateSaved` looks almost the same and confusing for me.
Probably `isBlinkRateSaved` would be better to highlight boolean variable.

-------------

PR: https://git.openjdk.org/jdk20/pull/21



More information about the client-libs-dev mailing list