[jdk20] RFR: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus [v3]
Alexander Zuev
kizune at openjdk.org
Sat Dec 17 18:21:10 UTC 2022
On Sat, 17 Dec 2022 01:08:12 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Handle different cases where refresh rate can be set when component is in different states causing some confused result.
>> Also added code that in case of non-editable text component reports the saved blink rate to avoid any problems with JCK testing.
>
> src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 370:
>
>> 368:
>> 369: private int savedBlinkRate = 0;
>> 370: private boolean blinkRateSaved = false;
>
> Naming of `savedBlinkRate` and `blinkRateSaved` looks almost the same and confusing for me.
> Probably `isBlinkRateSaved` would be better to highlight boolean variable.
Fixed.
-------------
PR: https://git.openjdk.org/jdk20/pull/21
More information about the client-libs-dev
mailing list