RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v5]

Harshitha Onkar duke at openjdk.java.net
Fri Feb 4 06:40:12 UTC 2022


On Thu, 27 Jan 2022 09:31:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed the test case condition and marked the test as mac-only
>
> test/jdk/javax/swing/JTableHeader/8016524/Bug8016524.java line 106:
> 
>> 104:         if(lowerLeft.getRGB() == WHITE_RGB || lowerRight.getRGB() == WHITE_RGB)
>> 105:         {
>> 106:             throw new RuntimeException("JTableHeader Bottom Border not visible");
> 
> Not sure this check is correct. If we have dark theme or the background is changed in system, then I guess the test will fail even with fix. Maybe you can set the JTable background to white explicitly.

@prsadhuk The fix and test case is ready for review. I have marked the testcase as mac-only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7219



More information about the client-libs-dev mailing list