RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v5]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Mon Feb 7 08:59:12 UTC 2022
On Fri, 4 Feb 2022 06:36:59 GMT, Harshitha Onkar <duke at openjdk.java.net> wrote:
>> test/jdk/javax/swing/JTableHeader/8016524/Bug8016524.java line 106:
>>
>>> 104: if(lowerLeft.getRGB() == WHITE_RGB || lowerRight.getRGB() == WHITE_RGB)
>>> 105: {
>>> 106: throw new RuntimeException("JTableHeader Bottom Border not visible");
>>
>> Not sure this check is correct. If we have dark theme or the background is changed in system, then I guess the test will fail even with fix. Maybe you can set the JTable background to white explicitly.
>
> @prsadhuk The fix and test case is ready for review. I have marked the testcase as mac-only.
I see it fails for me in mac 10.15..DId you see it pass locally for you and in CI systems? Also, it should show 3 rows including row showing "A""B""C" as it is shown in windows/ubuntu, why it is showing only 1 row here?
<img width="1044" alt="Screenshot 2022-02-07 at 2 19 08 PM" src="https://user-images.githubusercontent.com/43534309/152755889-a148fd24-3b62-4e86-a3f5-5b8c0c989f77.png">
-------------
PR: https://git.openjdk.java.net/jdk/pull/7219
More information about the client-libs-dev
mailing list