RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated
Phil Race
prr at openjdk.java.net
Tue Feb 15 17:47:06 UTC 2022
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy <duke at openjdk.java.net> wrote:
> Updated Parser class doc by appending to the doc regarding lack of support for HTML script tags. Adding this information to the "parse" function did not seem as consistent for formatting as adding it to the Parser class doc.
Do we have a test that proves what happens ?
I see the code you mention that logs an error but when I trace that it ends up in
handleError() which has an entirely commented out body. Whereas the bug report says that
the content of the script tag is displayed .. perhaps that latter part is true ?
But I am also confused because I see :-
if (recent == dtd.script) { // means: if after starting <script> tag
/* Here, ch has to be the first character after <script> */
parseScript();
Perhaps this is the code that displays the text of the script as described ?
But you wrote :-
* the script tag will be handled by <code>handleComment</code>.
FWIW it is inappropriate to write the method that will be called in the spec.
Instead - if actually accurate - you'd be saying something more like
"The body of the tag will be handled as if it were a comment".
However if it is displayed, I don't know if I believe that since HTML comments aren't displayed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7446
More information about the client-libs-dev
mailing list