RFR: 8281569: Create tests for Frame.setMinimumSize() method

[Alexey Ivanov]

On Fri, 11 Feb 2022 17:28:09 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

> Create tests for setMinimumSize functionality
> Create a test which verifies that on increasing the Frame's minimumSize, it gets reflected in the subsequent getSize call
> Create a test which verifies that on frame resizes back to minimumSize on calling pack.

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 40:

> 38: 
> 39:     private static Frame frame;
> 40:     private static Dimension dimension;

The `dimension` field should be volatile as it's accessed from different threads.

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 44:

> 42:     public static void createGUI(Frame _frame) {
> 43:         frame.add(new Button("Button"));
> 44:         frame.setSize(140,140);

Suggestion:

        frame.setSize(140, 140);

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 52:

> 50:         try {
> 51:             frame = new Frame();
> 52:             EventQueue.invokeAndWait(() -> createGUI(frame));

If you create other GUI components, you should create the frame inside `createGUI` method.

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 83:

> 81:     public static void main(String[] args) throws Exception {
> 82: 
> 83:         SetMinimumSizeTest1.doTest();

Suggestion:

        doTest();

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java line 44:

> 42:     public static void createGUI(Frame _frame) {
> 43:         frame.add(new Button("Button"));
> 44:         frame.setMinimumSize(new Dimension(140,140));

Suggestion:

        frame.setMinimumSize(new Dimension(140, 140));

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java line 91:

> 89:         SetMinimumSizeTest2.doTest();
> 90: 
> 91:     }

Suggestion:

    public static void main(String[] args) throws Exception {
        doTest();
    }

-------------

PR: https://git.openjdk.java.net/jdk/pull/7444