RFR: 8281569: Create tests for Frame.setMinimumSize() method

Alexey Ivanov aivanov at openjdk.java.net
Mon Feb 21 20:49:53 UTC 2022


On Fri, 11 Feb 2022 17:28:09 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

> Create tests for setMinimumSize functionality
> Create a test which verifies that on increasing the Frame's minimumSize, it gets reflected in the subsequent getSize call
> Create a test which verifies that on frame resizes back to minimumSize on calling pack.

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 55:

> 53: 
> 54:             Robot robot = new Robot();
> 55:             robot.setAutoDelay(100);

And add

robot.waitForIdle();

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java line 68:

> 66:             robot.waitForIdle();
> 67: 
> 68:             Dimension actualDimension = frame.getSize();

Let's be consistent: this should also be called on EDT.

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java line 55:

> 53: 
> 54:             Robot robot = new Robot();
> 55:             robot.setAutoDelay(100);

Also add

robot.waitForIdle();

test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java line 74:

> 72:             robot.waitForIdle();
> 73: 
> 74:             Dimension actualDimension = frame.getSize();

Let's be consistent and access `frame` on EDT only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7444



More information about the client-libs-dev mailing list