RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn

Phil Race prr at openjdk.java.net
Thu Jan 27 00:40:31 UTC 2022


On Wed, 26 Jan 2022 06:53:42 GMT, Toshio Nakamura <tnakamura at openjdk.org> wrote:

> JInternalFrame's bottom area is not properly drawn with Aqua LAF.
> This problem remained for long time, but we recognized it recently.
> 
> According to the bug report, it depends on MacOS's version. I don't have old ones (10.10 and 10.11 in the report), but the current MacOS can recreate the issue. I confirmed the following OS versions recreated this issue and this patch could solve it.
> 
> Mojave 10.14.6
> Catalina 10.15.7
> Big Sur 11.6.2
> Monterey 12.1
> 
> jtreg "javax/swing" and "java/awt" have no regression.

Looks so much better.

test/jdk/javax/swing/plaf/aqua/JInternalFrameBorderTest.java line 59:

> 57:             UIManager.setLookAndFeel("com.apple.laf.AquaLookAndFeel");
> 58:         } catch (Exception e) {
> 59:             throw new RuntimeException("Cannot initialize Aqua L&F");

Really this should not be needed since it is the default. But it should at least stop folks running it on Windows.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7228



More information about the client-libs-dev mailing list