RFR: JDK-6998249: Wrong behavior/Javadoc of JTable.tableChanged(TableModelEvent e)
Harshitha Onkar
duke at openjdk.java.net
Fri Jan 28 02:18:11 UTC 2022
On Fri, 28 Jan 2022 00:44:07 GMT, Phil Race <prr at openjdk.org> wrote:
>> Updated JTable's tableChanged() method docs to explicitly mention the coordinate system of the rows and columns.
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 4423:
>
>> 4421: * coordinate system of the view for the row; the appropriate
>> 4422: * mapping to the view coordinate system is performed by this
>> 4423: * <code>JTable</code> when it receives the event.
>
> A few things
> - since most of the doc is changing we can update to use the more modern {@code ...} instead
> - the 2nd clause is now only about the columns so should say "the appropriate mapping of the column to"
> - there's no @param tag .. how come doclint isn't complaining ? But we should fix it.
> - This will require a CSR.
> Oh and I assume you can confirm that you verified the above is 100% true .. and there's no need to mention RowSorter - can you point to where the event is created ?
@prrace Should all instances of "code tags" (entire JTable) changed to {@code...} or for the tableChanged method only?
I was not able to understand the last point clearly. Can you please elaborate?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7253
More information about the client-libs-dev
mailing list