RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB

Abhishek Kumar duke at openjdk.org
Fri Jul 1 04:31:24 UTC 2022


On Thu, 30 Jun 2022 16:56:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> JFileChooser - empty file size issue fixed. 
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> test/jdk/javax/swing/JFileChooser/ZeroFileSizeCheck.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 1999, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> The copyright year is usually just the current year for new files. 
> Was the test case created from a reproducer code?

@

> The copyright year is usually just the current year for new files. Was the test case created from a reproducer code?

I have taken sample test case from the repo for reference and write mine test case, will update the copyright year.

> test/jdk/javax/swing/JFileChooser/ZeroFileSizeCheck.java line 74:
> 
>> 72:             PassFailJFrame.positionTestFrame(frame,
>> 73:                     PassFailJFrame.Position.HORIZONTAL);
>> 74:         });
> 
> @kumarabhi006 You will have to update `addTestFrame & positonTestFrame` to `addTestWindow & positionTestWindow` due to recent PassFailJFrame changes. Probably pull in the latest code.
> PassFailJFrame changes: https://github.com/openjdk/jdk/pull/9300

@honkar-jdk @aivanov-jdk I will update the PassFailFrame changes.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list