Integrated: 8288444: Remove the workaround for frame.pack() in ModalDialogTest

Harshitha Onkar honkar at openjdk.org
Fri Jul 1 09:11:58 UTC 2022


On Fri, 24 Jun 2022 22:12:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Previously frame.pack() was called twice as a workaround  AWT frame sizing issue in this particular test case on Windows. This issue was fixed **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the workaround is being removed from this test.
> 
> PassFailJFrame is being used as the test framework. 
> 
> **Proposed change related to PassFailJFrame Test framework**
> 
> Instead of creating separate methods to handle AWT Windows as well as Frames, method signatures - [**PassFailJFrame.positionTestFrame()**](https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L271) and [**PassFailJFrame.addTestFrame()**](https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L294) can be changed to take in Window as input parameter instead of Frame, since Window is a superclass, this would allow the test frame to be a Window/Frame/Dialog and not be restricted to a Frame, additionally would allow proper disposal of windows added to the PassFailJFrame.
> 
> **Above PassFailJFrame changes tracked by: [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238)**

This pull request has now been integrated.

Changeset: f190f4e6
Author:    Harshitha Onkar <honkar at openjdk.org>
Committer: Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f190f4e6389a0105b0701ec7ea201fab9dda0a48
Stats:     359 lines in 1 file changed: 359 ins; 0 del; 0 mod

8288444: Remove the workaround for frame.pack() in ModalDialogTest

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/9286



More information about the client-libs-dev mailing list