RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v3]

Naoto Sato naoto at openjdk.org
Wed Jul 6 16:21:43 UTC 2022


On Wed, 6 Jul 2022 11:59:31 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

>> JFileChooser - empty file size issue fixed. 
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Byte entry added to basic.properties, MessageFormat used to format file length

src/java.desktop/share/classes/sun/swing/FilePane.java line 1194:

> 1192:                 setIcon(icon);
> 1193: 
> 1194:             } else if (value instanceof Long) {

You could change this to `value instanceof Long len` so that the cast below can be eliminated.

test/jdk/javax/swing/JFileChooser/ZeroFileSizeCheck.java line 78:

> 76:         passFailJFrame.awaitAndCheck();
> 77:     }
> 78: }

Needs a newline.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list