RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v3]

Abhishek Kumar duke at openjdk.org
Thu Jul 7 07:10:29 UTC 2022


On Wed, 6 Jul 2022 16:15:22 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Byte entry added to basic.properties, MessageFormat used to format file length
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1194:
> 
>> 1192:                 setIcon(icon);
>> 1193: 
>> 1194:             } else if (value instanceof Long) {
> 
> You could change this to `value instanceof Long len` so that the cast below can be eliminated.

After replacing "value instanceof Long" by "value instanceof Long len" and removing the cast below (long len = value) results in build error. So, I guess cast is required to convert an object to long type.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list