RFR: 8267374: (macos) Left Option+Up/Down arrow dont traverse to beginning/end of line in textarea [v5]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Jul 12 11:01:51 UTC 2022


On Fri, 8 Jul 2022 08:02:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 95:
>> 
>>> 93:         "alt altgraph LEFT", DefaultEditorKit.previousWordAction,
>>> 94:         "alt altgraph RIGHT", DefaultEditorKit.nextWordAction,
>>> 95:         "alt UP", DefaultEditorKit.beginLineUpAction,
>> 
>> I find it utterly bizarre to say we need "altgraph" when macOS doesn't have altgraph - certainly not on the k/bs on current mac books or imacs.
>> 
>> My take is that the previous fix JDK-8151136 was a mistake and we should have just excluded the test there on macOS.
>
> As per offline discussion with @prrace ALT_GRAPH support done via JDK-8151136 is reverted and tests testing ALT_GRAPH in macos is excluded..
> @prrace can you please review?

Even if JavaFX, Left and Right Option key is mapped to ALT so I guess we will be consistent with that too.

-------------

PR: https://git.openjdk.org/jdk/pull/9230



More information about the client-libs-dev mailing list