RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v4]

SWinxy duke at openjdk.org
Sat Jul 16 16:31:31 UTC 2022


> The current implementation creates ~750 new objects on load, and uses a binary array search with a Comparable implementation. This implementation is probably bad. Instead, we can use the enhanced switch feature to possibly save time, resources, and code size. The new implementation means that the array doesn't have to be sorted alphanumerically necessarily, and it creates the colors on demand.

SWinxy has updated the pull request incrementally with one additional commit since the last revision:

  Alter XColor documentation
  
  Let's see if this passes the checks

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/7096/files
  - new: https://git.openjdk.org/jdk/pull/7096/files/32640e43..09d5d0ed

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=7096&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=7096&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/7096.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/7096/head:pull/7096

PR: https://git.openjdk.org/jdk/pull/7096



More information about the client-libs-dev mailing list