RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v4]
Phil Race
prr at openjdk.org
Mon Jul 18 17:22:11 UTC 2022
On Sat, 16 Jul 2022 16:31:31 GMT, SWinxy <duke at openjdk.org> wrote:
>> The current implementation creates ~750 new objects on load, and uses a binary array search with a Comparable implementation. This implementation is probably bad. Instead, we can use the enhanced switch feature to possibly save time, resources, and code size. The new implementation means that the array doesn't have to be sorted alphanumerically necessarily, and it creates the colors on demand.
>
> SWinxy has updated the pull request incrementally with one additional commit since the last revision:
>
> Alter XColor documentation
>
> Let's see if this passes the checks
1) The test suites are NOT preventing integration
2) The tests run here are IRRELEVANT to client changes - NO CLIENT TESTS ARE RUN by GHA. Not a single one.
If any client tests need to be run you will need to do it yourself
3) the sponsor label was removed when I requested changes which you have made since
It looks to me as if you can just type /integrate again
-------------
PR: https://git.openjdk.org/jdk/pull/7096
More information about the client-libs-dev
mailing list