RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v13]

Andy Goryachev angorya at openjdk.org
Thu Jul 28 15:36:49 UTC 2022


On Wed, 27 Jul 2022 17:37:00 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   space added as per review comment
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1233:
> 
>> 1231: 
>> 1232:         public double formatToDoubleValue(long len) {
>> 1233:             DecimalFormat df = new DecimalFormat("0.0");
> 
> DecimalFormat("0.0") does not provide locale-specific group separator, which may come to play.
> for example "1,000 TB"

also, it always formats numbers to have one decimal point, even for whole numbers (10.0)
is this intended functionality?  should "0.#" be used instead?

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list