RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v13]

Abhishek Kumar duke at openjdk.org
Thu Jul 28 16:11:44 UTC 2022


On Thu, 28 Jul 2022 15:32:50 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/swing/FilePane.java line 1233:
>> 
>>> 1231: 
>>> 1232:         public double formatToDoubleValue(long len) {
>>> 1233:             DecimalFormat df = new DecimalFormat("0.0");
>> 
>> DecimalFormat("0.0") does not provide locale-specific group separator, which may come to play.
>> for example "1,000 TB"
>
> also, it always formats numbers to have one decimal point, even for whole numbers (10.0)
> is this intended functionality?  should "0.#" be used instead?

Group separator may come into picture if file size is in terms of TB, otherwise for files having sizes in bytes , KB, MB and so on will be converted to next higher unit if size > 999.

e.g. 
1000 bytes - 1KB
1000 KB - 1 MB and so on...

So, I guess group separator may not come into play.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list