RFR: 8282526: Default icon is not painted properly [v4]

[Alexander Zuev]

On Mon, 14 Mar 2022 02:29:47 GMT, Jeremy <duke at openjdk.java.net> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use small icon pointer for icons less than 24 pixels wide - this way we
>>   get the 16x16 icon which is better for scaling purposes.
>
> test/jdk/javax/swing/ImageIcon/MultiResolutionImageIcon.java line 127:
> 
>> 125:         return null;
>> 126:     }
>> 127: }
> 
> This test reads a little strange to me. (I'm not an official openjdk reviewer, though, so feel free to disregard.)
> 
> If I run this test with the existing ImageIcon class it creates an image that resembles:
> ![image](https://user-images.githubusercontent.com/7669569/158093894-be7a73c6-6936-4725-bb09-cd054a2dccc2.png)
> 
> If I run this test with the revised code it creates an image that resembles:
> ![image](https://user-images.githubusercontent.com/7669569/158093939-bffc62c7-7a5c-4b0e-b71e-710c5049daf6.png)
> 
> Based on the changes in ImageIcon: I only expected to see changes related to rendering hints. (That is: I expected to see differences in antialiasing and scaling artifacts.)
> 
> Would you mind if I proposed a different test?

Well, the difference in the images generated is the demonstration of how significant parts of the original image gets lost during the rendering. Not sure why you think this test is not valid.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7805